fix(Command): remove invalid data-[disabled] attribute
#1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`aria-selected`=> `data-[selected]`
|
@kevinmitch14 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
SoyDiego
approved these changes
Nov 22, 2023
|
This has been updated in the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmdk's README.md states that
[data-disabled]is available on<Command.Item />. However since the PR that made this data attribute available, there has been no releases. As a result the styling using this data attribute is not being applied.While making these changes I realised
aria-selectedis also being used for styling, so I switched this to use the data attribute,data-selected, which is applied by cmdk.I created an issue on cmdk repo here, pacocoursey/cmdk#192 and will follow this but there is no indication when this will be addressed or if there will be a new release.
Before w/ Calendar CommandItem disabled:
After w/ Calendar CommandItem disabled:
